Askhat/askhat
Archived
Template
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: edits to existing deals not saving

Browse Source 
Hidden input was named "id", which collided with form.id
(standard DOM property returning the form element's id attribute,
not the named control). FormData.get("id") returned empty,
so submit always created a new deal instead of updating.

Renamed field to "dealId" and updated all references.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
askhat 2026-05-19 14:57:43 +05:00
parent 94f5d6a56b
commit c726bf9d36
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
assets/app.js
View File

@ -149,7 +149,7 @@ function openDealModal(id){
if(id){ if(id){
const d = window.Store.get(id); const d = window.Store.get(id);
if(!d) return; if(!d) return;
form.id.value = d.id; form.dealId.value = d.id;
form.company.value = d.company; form.company.value = d.company;
form.product.value = d.product || ""; form.product.value = d.product || "";
form.manager.value = d.manager; form.manager.value = d.manager;
@ -190,7 +190,7 @@ function bindEvents(){
$("#deal-form").addEventListener("submit", e => { $("#deal-form").addEventListener("submit", e => {
e.preventDefault(); e.preventDefault();
const fd = new FormData(e.target); const fd = new FormData(e.target);
const id = fd.get("id") || null; const id = fd.get("dealId") || null;
const existing = id ? window.Store.get(id) : null; const existing = id ? window.Store.get(id) : null;
const statusText = (fd.get("currentStatus") || "").trim(); const statusText = (fd.get("currentStatus") || "").trim();
const oldStatus = existing ? (existing.currentStatus || "") : ""; const oldStatus = existing ? (existing.currentStatus || "") : "";
@ -224,7 +224,7 @@ function bindEvents(){
}); });
$("#delete-deal").addEventListener("click", () => { $("#delete-deal").addEventListener("click", () => {
const id = $("#deal-form").id.value; const id = $("#deal-form").dealId.value;
if(!id) return; if(!id) return;
if(!confirm("Удалить сделку?")) return; if(!confirm("Удалить сделку?")) return;
window.Store.remove(id); window.Store.remove(id);

2
index.html
View File

@ -134,7 +134,7 @@ td.status-cell textarea:focus{background:#fff;outline:2px solid var(--primary)}
<button class="modal-close" id="modal-close" type="button">✕</button> <button class="modal-close" id="modal-close" type="button">✕</button>
<h3 id="modal-title">Сделка</h3> <h3 id="modal-title">Сделка</h3>
<form id="deal-form"> <form id="deal-form">
<input type="hidden" name="id"> <input type="hidden" name="dealId">
<label>Компания <input name="company" required></label> <label>Компания <input name="company" required></label>
<label>Название продукта/услуги <input name="product" placeholder="например: CRM-внедрение"></label> <label>Название продукта/услуги <input name="product" placeholder="например: CRM-внедрение"></label>
<label>Менеджер <label>Менеджер